Author Topic: got the scrolling working  (Read 12412 times)

z80_fr

  • Jr. Member
  • **
  • Posts: 71
  • Gender: Male
got the scrolling working
« on: 06.03.2007 at 20:36:31 »
I didn't ask for write permission on the repository ...

http://68hc11.free.fr/ypod/main.zip

still some fixe to do like reset scrolling position to zero when selecting Next song or previous song in the play menu...

Also working on a "ping - pong" style scroller.

kay1234

  • Jr. Member
  • **
  • Posts: 88
  • Gender: Male
Re: got the scrolling working
« Reply #1 on: 06.03.2007 at 21:01:17 »
Nice, works fine here.  8) When it is stable the next idea would be to have the file list scroll as well as soon as the "cursor" stops on a line which is too long to display...  ;D

MIC

  • YaBB God
  • *****
  • Posts: 648
  • Yampp3/USB - THE AUDIENCE IS LISTENING
Re: got the scrolling working
« Reply #2 on: 07.03.2007 at 20:13:31 »
The scrolling code has been added to the actual SVN code.
/Michael

.:: www.mictronics.de ::.

z80_fr

  • Jr. Member
  • **
  • Posts: 71
  • Gender: Male
Re: got the scrolling working
« Reply #3 on: 07.03.2007 at 21:57:24 »
New version of scroller available

Now you got usual scroller for title name
and ping pong style scroller for album name.

here is the file
http://68hc11.free.fr/ypod/main2.zip

Maybe some optimize could be done but I got to go and say lovely word to my wife.... If I want to stay alive...

good night everybody!

Jeepman

  • Full Member
  • ***
  • Posts: 121
Re: got the scrolling working
« Reply #4 on: 08.03.2007 at 13:40:14 »
Hi,

You did a nice work but i think that the scroll should be enabled only if the string is larger than the screen !
Salutations !
Eric G.

z80_fr

  • Jr. Member
  • **
  • Posts: 71
  • Gender: Male
Re: got the scrolling working
« Reply #5 on: 08.03.2007 at 20:40:24 »
It does work that way!

take care that your ID3tag is well filled, I mean without "space" char.
I find some of mine with this mess. The one I got from Mucky-Pup in the Act of Faith album...

I have actualy no problem with well filled MP3 files.

Jesper Hansen

  • Administrator
  • YaBB God
  • *****
  • Posts: 1618
  • ypod? ynot?
Re: got the scrolling working
« Reply #6 on: 09.03.2007 at 00:27:32 »
It would be simple to strip off trailing spaces from the ID3 tags, so that is easily solved.
If electricity comes from electrons, does morality come from morons ?

Ulrich Behrenbeck

  • Sr. Member
  • ****
  • Posts: 400
  • what colour ? red ? blue ? ...
Re: got the scrolling working
« Reply #7 on: 09.03.2007 at 12:42:54 »
What about Unicode tag support?
yes - no  -maybe  -i don't know - can you repeat the question ?

z80_fr

  • Jr. Member
  • **
  • Posts: 71
  • Gender: Male
Re: got the scrolling working
« Reply #8 on: 09.03.2007 at 13:15:57 »
It would be simple to strip off trailing spaces from the ID3 tags, so that is easily solved.

In my point of vue, it should be done by ID3tag lib.

I also wonder why the char code above "z" or something like that aren't implemanted in the font.
Why not following the LCD 2x16 char with there "almost international" char code ROM of 255 char?

MIC

  • YaBB God
  • *****
  • Posts: 648
  • Yampp3/USB - THE AUDIENCE IS LISTENING
Re: got the scrolling working
« Reply #9 on: 09.03.2007 at 14:13:45 »
Quote
In my point of vue, it should be done by ID3tag lib.
I will look into that.

Quote
I also wonder why the char code above "z" or something like that aren't implemanted in the font.
Why not following the LCD 2x16 char with there "almost international" char code ROM of 255 char?

To limit the amount of flash program space used by the font set's.
/Michael

.:: www.mictronics.de ::.

Jesper Hansen

  • Administrator
  • YaBB God
  • *****
  • Posts: 1618
  • ypod? ynot?
Re: got the scrolling working
« Reply #10 on: 09.03.2007 at 16:33:00 »
As code space is not as cramped as it was in the good old AVR days, we could add more characters. Also, although there is 3 fonts, we currently only use one, and I don't really see much need for the two others, so they could be dropped in exchange for more characters in the "main" font.
Fonts could also be loaded from the card, but that would consume RAM, which we want to save for games and plugins. Also, there would still need to be a default (but minimal) font.
If electricity comes from electrons, does morality come from morons ?

z80_fr

  • Jr. Member
  • **
  • Posts: 71
  • Gender: Male
Re: got the scrolling working
« Reply #11 on: 09.03.2007 at 19:31:49 »
About loading  font from SD card, could be done with small amount of char like the 2x16 does. Let say 8 or 16 char. But the LCD lib should be updated then.

I agree we need to keep RAM available for stuff and not using RAM for craps. This also why I want to optimize the amount of memory used for the scrolling routines, like changing the INT to UNSIGNED CHAR. I have to find out whar is the maximum size of the string for title name and album name.
Real cool stuff will be to alocate only required memory. But I'm not up to this point for the moment.

z80_fr

  • Jr. Member
  • **
  • Posts: 71
  • Gender: Male
Re: got the scrolling working
« Reply #12 on: 10.03.2007 at 22:33:16 »
Optimisation of the code for both scroller (standar scrolling and pin-pong style)

I've rewrote the code and put them in function so the same code is called for Title and Album (using parameters like: text buffer, locate on screen X,Y, and scroll position)

Can someone include the new code into the SVN?

If someone is working on config file, I've include the possibility for the AlbumName to choose between standar scrolling or ping-pong style scrolling.

Just change ScrollType (line 97 of main.c) to 0 or 1 according to the setting in the config file.

http://68hc11.free.fr/ypod/ypod.zip

Botosu

  • Full Member
  • ***
  • Posts: 230
  • Gender: Male
  • Fight Fire With the Fire
Re: got the scrolling working
« Reply #13 on: 17.03.2007 at 22:13:02 »
BIG PROBLEM with scrolling on fw0.35 (found on svn at 17.03.2007 23:00 GMT+2)

The Album Name text goes into the left, disappear and never come back correct.
From time to time a new strange char is added on display, they start to scroll into the left, but never the original name of the album.

z80_fr

  • Jr. Member
  • **
  • Posts: 71
  • Gender: Male
Re: got the scrolling working
« Reply #14 on: 17.03.2007 at 22:57:18 »
Should have something to do with clearing scroll varaible when calling the NEXT or PREVIOUS song. Noticed that already.
Check the function that call the NEXT and PREV. I did modify on my local version.
By the way I'll check again to be 100% sure.
Thank for the report.